Date ist verboten

.rubocop.yml

@@ -1,5 +1,8 @@
 inherit_from: .rubocop_todo.yml
 
+Rails:
+  Enabled: true
+
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # on 2018-12-24 11:44:14 +0100 using RuboCop version 0.60.0.

.rubocop_todo.yml

@@ -20,16 +20,6 @@ Rails/CreateTableWithTimestamps:
   Exclude:
     - 'db/migrate/20170210180426_remove_tokens_from_users.rb'
 
-# Offense count: 7
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/Date:
-  Exclude:
-    - 'app/controllers/groups_controller.rb'
-    - 'app/helpers/authentication_helper.rb'
-    - 'app/models/person.rb'
-    - 'db/seeds.rb'
-
 # Offense count: 1
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments

app/controllers/groups_controller.rb

@@ -25,7 +25,7 @@ class GroupsController < ApplicationController
                             .organized_activities
                             .joins(:activity)
                             .where('activities.group_id': @group.id)
-                            .where('start > ?', Date.today)
+                            .where('start > ?', Time.zone.today)
 
     @groupmenu = if @organized_activities.any?
                    'col-md-6'
@@ -34,7 +34,7 @@ class GroupsController < ApplicationController
                  end
 
     @upcoming = @group.activities
-                      .where('start > ?', Date.today)
+                      .where('start > ?', Time.zone.today)
                       .order('start ASC')
     @upcoming_ps = Participant
                    .where(person: current_person)

app/helpers/authentication_helper.rb

@@ -60,7 +60,7 @@ module AuthenticationHelper
   def logged_in?
     # Case 1: User has an active session inside the cookie.
     # We verify that the session hasn't expired yet.
-    if session[:user_id] && session[:expires].to_time.future?
+    if session[:user_id] && session[:expires]&.future?
 
       user_session
 

app/models/person.rb

@@ -190,7 +190,7 @@ class Person < ApplicationRecord
 
   # Assert that the person's birth date, if any, lies in the past.
   def birth_date_cannot_be_in_future
-    errors.add(:birth_date, I18n.t('person.errors.cannot_future')) if birth_date && birth_date > Date.today
+    errors.add(:birth_date, I18n.t('person.errors.cannot_future')) if birth_date&.future?
   end
 
   # Explicitly force nil to false in the admin field.

db/seeds.rb

@@ -13,7 +13,7 @@ its_me = Person.create!(
   first_name: 'Maarten',
   infix: 'van den',
   last_name: 'Berg',
-  birth_date: Faker::Date.between(21.years.ago, Date.today),
+  birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
   email: 'maarten@maartenberg.nl',
   is_admin: true
 )
@@ -29,7 +29,7 @@ User.create!(
 Person.create!(
   first_name: 'Henkie',
   last_name: 'Gekke',
-  birth_date: Faker::Date.between(21.years.ago, Date.today),
+  birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
   email: 'gekkehenkie@maartenberg.nl'
 )
 
@@ -47,7 +47,7 @@ end
   Person.create!(
     first_name: Faker::Name.first_name,
     last_name: Faker::Name.last_name,
-    birth_date: Faker::Date.between(21.years.ago, Date.today),
+    birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
     email: "testuser#{i}@maartenberg.nl"
   )
 end