Useless assignment, fix bug in log_out

.rubocop.yml

@@ -23,11 +23,6 @@ Lint/SafeNavigationChain:
   Exclude:
     - 'app/controllers/api_controller.rb'
 
-# Offense count: 4
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'db/seeds.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
@@ -42,12 +37,6 @@ Lint/UnusedMethodArgument:
   Exclude:
     - 'app/helpers/application_helper.rb'
 
-# Offense count: 8
-Lint/UselessAssignment:
-  Exclude:
-    - 'app/helpers/authentication_helper.rb'
-    - 'db/seeds.rb'
-
 # Offense count: 30
 Metrics/AbcSize:
   Max: 71

app/helpers/authentication_helper.rb

@@ -40,7 +40,7 @@ module AuthenticationHelper
   end
 
   # Determine whether the user is logged in, and if so, disable the Session, then flush session cookies.
-  def log_out(session_broken = false)
+  def log_out(session_broken: false)
     if !session_broken && is_logged_in? && @user_session
       get_user_session
 
@@ -104,7 +104,7 @@ module AuthenticationHelper
 
     # Edge case if a session no longer exists in the database
     if not @user_session
-      log_out(session_broken = true)
+      log_out(session_broken: true)
     end
   end
 

db/seeds.rb

@@ -9,7 +9,7 @@ require 'byebug'
 
 exit if Rails.env.production?
 
-p = Person.create!(
+its_me = Person.create!(
   first_name: 'Maarten',
   infix: 'van den',
   last_name: 'Berg',
@@ -18,33 +18,33 @@ p = Person.create!(
   is_admin: true
 )
 
-u = User.create!(
+User.create!(
   email: 'maarten@maartenberg.nl',
-  person: p,
+  person: its_me,
   password: 'aardbei123',
   password_confirmation: 'aardbei123',
   confirmed: true
 )
 
-p2 = Person.create!(
+Person.create!(
   first_name: 'Henkie',
   last_name: 'Gekke',
   birth_date: (Faker::Date.between(21.years.ago, Date.today)),
   email: 'gekkehenkie@maartenberg.nl'
 )
 
-g = Group.create!(
+default_test_group = Group.create!(
   name: 'Teststam'
 )
 
-2.times do |i|
-  gr = Group.create!(
+2.times do
+  Group.create!(
     name: Faker::Team.name
   )
 end
 
-15.times do |i|
-  person = Person.create!(
+15.times do
+  Person.create!(
     first_name: (Faker::Name.first_name),
     last_name: (Faker::Name.last_name),
     birth_date: (Faker::Date.between(21.years.ago, Date.today)),
@@ -52,23 +52,23 @@ end
   )
 end
 
-a = Activity.create!(
+Activity.create!(
   name: 'Fikkie stoken ofzo',
   description: 'Een scout trekt er samen met anderen op uit',
   location: 'In het bos in het bos',
   start: 4.weeks.since,
   end: 4.weeks.since + 2.hours,
   deadline: 3.weeks.since,
-  group: g
+  group: default_test_group
 )
 
 Group.all.each do |g|
-  10.times do |i|
+  10.times do
     starttime = Faker::Time.between(DateTime.now, 1.years.since, :morning)
     endtime   = Faker::Time.between(1.hours.since(starttime), 1.days.since(starttime), :afternoon)
     deadline  = 5.days.ago(starttime)
 
-    act = Activity.create!(
+    Activity.create!(
       name: Faker::Hacker.ingverb,
       description: Faker::Hipster.sentence,
       location: Faker::Address.city,
@@ -84,7 +84,7 @@ end
 Person.all.each do |p|
   Group.all.each do |g|
     if Faker::Boolean.boolean(0.75)
-      mem = Member.create!(
+      Member.create!(
         person: p,
         group: g,
         is_leader: Faker::Boolean.boolean(0.1)
@@ -96,7 +96,7 @@ Person.all.each do |p|
           notes = nil
         end
 
-        # Participants are created on adding to group!
+        # Participants are created on adding to group, no need to create
         part = Participant.find_by(
           activity: a,
           person: p