Conditional assignment

.rubocop.yml

@@ -58,18 +58,6 @@ Style/ColonMethodCall:
     - 'app/controllers/authentication_controller.rb'
     - 'app/models/token.rb'
 
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'app/controllers/activities_controller.rb'
-    - 'app/controllers/api/activities_controller.rb'
-    - 'app/controllers/groups_controller.rb'
-    - 'app/mailers/participant_mailer.rb'
-    - 'db/seeds.rb'
-
 # Offense count: 55
 Style/Documentation:
   Enabled: false

app/controllers/activities_controller.rb

@@ -24,17 +24,17 @@ class ActivitiesController < ApplicationController
   # GET /groups/:id/activities
   # GET /activities.json
   def index
-    if params[:past]
-      @activities = @group.activities
+    @activities = if params[:past]
+                    @group.activities
                           .where('start < ?', Time.now)
                           .order(start: :desc)
                           .paginate(page: params[:page], per_page: 25)
-    else
-      @activities = @group.activities
+                  else
+                    @group.activities
                           .where('start > ?', Time.now)
                           .order(start: :asc)
                           .paginate(page: params[:page], per_page: 25)
-    end
+                  end
   end
 
   # GET /activities/1
@@ -111,11 +111,7 @@ class ActivitiesController < ApplicationController
           raise ActiveRecord::Rollback
         end
 
-        if v != 'nil'
-          p.subgroup = sg
-        else
-          p.subgroup = nil
-        end
+        p.subgroup = (sg if v != 'nil')
 
         p.save
       end
@@ -190,11 +186,11 @@ class ActivitiesController < ApplicationController
     @participant.is_organizer = params[:new_state]
     @participant.save
 
-    if params[:new_state] == "true"
-      message = I18n.t('activities.organizers.added', name: @participant.person.full_name)
-    else
-      message = I18n.t('activities.organizers.removed', name: @participant.person.full_name)
-    end
+    message = if params[:new_state] == "true"
+                I18n.t('activities.organizers.added', name: @participant.person.full_name)
+              else
+                I18n.t('activities.organizers.removed', name: @participant.person.full_name)
+              end
     flash_message(:success, message)
 
     redirect_to edit_group_activity_path(@group, @activity, anchor: 'organizers-add')

app/controllers/api/activities_controller.rb

@@ -40,23 +40,23 @@ module Api
 
       absentnames = absent.map { |p| p.person.first_name }
 
-      if presentnames.positive?
-        present_mess = I18n.t('activities.participant.these_present', count: present.count, names: presentnames.join(', '))
-      else
-        present_mess = I18n.t('activities.participant.none_present')
-      end
-
-      if unknownnames.positive?
-        unknown_mess = I18n.t('activities.participant.these_unknown', count: unknown.count, names: unknownnames.join(', '))
-      else
-        unknown_mess = I18n.t('activities.participant.none_unknown')
-      end
-
-      if absentnames.positive?
-        absent_mess = I18n.t('activities.participant.these_absent', count: absent.count, names: absentnames.join(', '))
-      else
-        absent_mess = I18n.t('activities.participant.none_absent')
-      end
+      present_mess = if presentnames.positive?
+                       I18n.t('activities.participant.these_present', count: present.count, names: presentnames.join(', '))
+                     else
+                       I18n.t('activities.participant.none_present')
+                     end
+
+      unknown_mess = if unknownnames.positive?
+                       I18n.t('activities.participant.these_unknown', count: unknown.count, names: unknownnames.join(', '))
+                     else
+                       I18n.t('activities.participant.none_unknown')
+                     end
+
+      absent_mess = if absentnames.positive?
+                      I18n.t('activities.participant.these_absent', count: absent.count, names: absentnames.join(', '))
+                    else
+                      I18n.t('activities.participant.none_absent')
+                    end
 
       @summary = {
         present: {

app/controllers/groups_controller.rb

@@ -27,11 +27,11 @@ class GroupsController < ApplicationController
                             .where('activities.group_id': @group.id)
                             .where('start > ?', Date.today)
 
-    if @organized_activities.any?
-      @groupmenu = 'col-md-6'
-    else
-      @groupmenu = 'col-md-12'
-    end
+    @groupmenu = if @organized_activities.any?
+                   'col-md-6'
+                 else
+                   'col-md-12'
+                 end
 
     @upcoming = @group.activities
                       .where('start > ?', Date.today)

app/mailers/participant_mailer.rb

@@ -3,11 +3,11 @@ class ParticipantMailer < ApplicationMailer
     @person = person
     @activity = activity
 
-    if activity.no_response_action # is true
-      key = 'activities.emails.attendance_reminder.subject_present'
-    else
-      key = 'activities.emails.attendance_reminder.subject_absent'
-    end
+    key = if activity.no_response_action # is true
+            'activities.emails.attendance_reminder.subject_present'
+          else
+            'activities.emails.attendance_reminder.subject_absent'
+          end
 
     subject = I18n.t(key, activity: @activity.name)
 

db/seeds.rb

@@ -91,11 +91,7 @@ Person.all.each do |p|
       is_leader: Faker::Boolean.boolean(0.1)
     )
     g.activities.each do |a|
-      if Faker::Boolean.boolean(0.15)
-        notes = Faker::Hipster.sentence
-      else
-        notes = nil
-      end
+      notes = (Faker::Hipster.sentence if Faker::Boolean.boolean(0.15))
 
       # Participants are created on adding to group, no need to create
       part = Participant.find_by(