Subgroup mailing works

app/controllers/activities_controller.rb

@@ -228,7 +228,7 @@ class ActivitiesController < ApplicationController
 
     # Never trust parameters from the scary internet, only allow the white list through.
     def activity_params
-      params.require(:activity).permit(:name, :description, :location, :start, :end, :deadline, :reminder_at)
+      params.require(:activity).permit(:name, :description, :location, :start, :end, :deadline, :reminder_at, :subgroup_division_enabled)
     end
 
     def subgroup_params

app/mailers/participant_mailer.rb

@@ -7,4 +7,32 @@ class ParticipantMailer < ApplicationMailer
 
     mail(to: @person.email, subject: subject)
   end
+
+  def subgroup_notification(person, activity, participant)
+    @person = person
+    @activity = activity
+
+    @subgroup = participant.subgroup.name
+
+    @others = participant
+      .subgroup
+      .participants
+      .where.not(person: @person)
+      .map { |pp| pp.person.full_name }
+      .sort
+      .join(', ')
+
+    @subgroups = @activity
+      .subgroups
+      .order(name: :asc)
+
+    @organizers = @activity
+      .organizer_names
+      .sort
+      .join(', ')
+
+    subject = I18n.t('activities.emails.subgroup_notification.subject', subgroup: @subgroup, activity: @activity.name)
+
+    mail(to: @person.email, subject: subject)
+  end
 end

app/models/activity.rb

@@ -79,6 +79,10 @@ class Activity < ApplicationRecord
     self.participants.includes(:person).where(is_organizer: true)
   end
 
+  def organizer_names
+    self.organizers.map { |o| o.person.full_name }
+  end
+
   # Determine whether the passed Person participates in the activity.
   def is_participant?(person)
     Participant.exists?(
@@ -205,11 +209,11 @@ class Activity < ApplicationRecord
   def schedule_subgroup_division
     return if self.deadline.nil? || self.subgroup_division_done
 
-    self.delay(run_at: self.deadline).assign_subgroups!
+    self.delay(run_at: self.deadline).assign_subgroups!(mail: true)
   end
 
   # Assign a subgroup to all attending participants without one.
-  def assign_subgroups!
+  def assign_subgroups!(mail= false)
     # Sanity check: we need subgroups to divide into.
     return unless self.subgroups.any?
 
@@ -240,6 +244,22 @@ class Activity < ApplicationRecord
       # Update the group's position in the list, will sort when next participant is processed.
       groups.first[0] += 1
     end
+
+    if mail
+      self.notify_subgroups!
+    end
+  end
+
+  # Notify participants of the current subgroups, if any.
+  def notify_subgroups!
+    ps = self
+      .participants
+      .joins(:person)
+      .where.not(subgroup: nil)
+
+    ps.each do |pp|
+      pp.send_subgroup_notification
+    end
   end
 
   private
@@ -266,4 +286,11 @@ class Activity < ApplicationRecord
       errors.add(:reminder_at, I18n.t('activities.errors.must_be_before_deadline'))
     end
   end
+
+  # Assert that there is at least one divisible subgroup.
+  def subgroups_for_division_present
+    if self.subgroups.where(is_assignable: true).none?
+      errors.add(:subgroup_division_enabled, I18n.t('activities.errors.cannot_divide_without_subgroups'))
+    end
+  end
 end

app/models/participant.rb

@@ -57,4 +57,11 @@ class Participant < ApplicationRecord
     ParticipantMailer.attendance_reminder(self.person, self.activity).deliver_later
   end
 
+  # Send subgroup information email if person is attending.
+  def send_subgroup_notification
+    return unless self.attending && self.subgroup
+
+    ParticipantMailer.subgroup_notification(self.person, self.activity, self).deliver_later
+  end
+
 end

app/models/subgroup.rb

@@ -4,4 +4,12 @@ class Subgroup < ApplicationRecord
 
   validates :name, presence: true, uniqueness: { scope: :activity, case_sensitive: false }
   validates :activity, presence: true
+
+  def participant_names
+    self
+      .participants
+      .joins(:person)
+      .map { |p| p.person.full_name }
+      .sort
+  end
 end

app/views/participant_mailer/subgroup_notification.html.haml

@@ -0,0 +1,34 @@
+%p= t 'authentication.emails.greeting', name: @person.first_name
+
+%p= t 'activities.emails.subgroup_notification.yoursubgroupis', activity: @activity.name, subgroup: @subgroup
+
+- if !@others.empty?
+  %p= t 'activities.emails.subgroup_notification.subgroupmembers', others: @others
+- else
+  %p= t 'activities.emails.subgroup_notification.noothersinsubgroup'
+
+%p= t 'activities.emails.subgroup_notification.allsubgroups'
+%ul
+  - @subgroups.each do |sg|
+    %li
+      = succeed ':' do
+        = sg.name
+      = sg.participant_names.join ', '
+
+%p= t 'activities.emails.subgroup_notification.cannotdecline', organizers: @organizers
+
+%p
+  = link_to group_activity_url(@activity.group, @activity) do
+    = t 'activities.emails.open_activity'
+
+%p
+  = t('activities.emails.ending').sample
+  %br
+  Aardbei
+
+%hr
+%footer
+  %p
+    = t 'activities.emails.dont_want_mail'
+    %a{href: "https://aardbei.maartenberg.nl/settings"}
+      = t 'activities.emails.open_settings'

app/views/participant_mailer/subgroup_notification.text.erb

@@ -0,0 +1,26 @@
+<%= t 'authentication.emails.greeting', name: @person.first_name %>
+
+<%= t 'activities.emails.subgroup_notification.yoursubgroupis', activity: @activity.name, subgroup: @subgroup %>
+
+<% if !@others.empty? %>
+<%= t 'activities.emails.subgroup_notification.subgroupmembers', others: @others %>
+<% else %>
+<%= t 'activities.emails.subgroup_notification.noothersinsubgroup' %>
+<% end %>
+
+<%= t 'activity.emails.subgroup_notification.allsubgroups' %>
+
+<% @subgroups.each do |sg| %>
+- <%= sg.name %>: <%= sg.participant_names.join(', ') %>
+<% end %>
+
+<%= t 'activity.emails.subgroup_notification.cannotdecline', organizers: @organizers %>
+
+<%= group_activity_url(@activity.group, @activity) %>
+
+<%= t('activities.emails.ending').sample %>
+Aardbei
+
+---
+<%= t 'activities.emails.dont_want_mail' %>
+https://aardbei.maartenberg.nl/settings

config/locales/activities/en.yml

@@ -78,6 +78,13 @@ en:
         havenot_responded: "You have not yet indicated if you will be at %{activity}. Because we assume that you're present if you don't respond, your response has been set to 'attending'."
         if_cannot: "If you wish to change this, you can change your response until %{deadline} using the following link:"
 
+      subgroup_notification:
+        subject: "You have been assigned to subgroup %{subgroup} for %{activity}"
+        yoursubgroupis: "The upcoming activity %{activity} uses subgroups, and you have been assigned to subgroup %{subgroup}."
+        subgroupmembers: "The other people in this subgroup are: %{others}"
+        allsubgroups: "All subgroups (including yours):"
+        cannotdecline: "This email was sent when the deadline expired. If you find you cannot attend, please contact the Drerrie, or one of the organisers (%{organizers})."
+
     subgroups:
       manage: 'Manage subgroups'
       create: 'Create subgroup'

config/locales/activities/nl.yml

@@ -84,6 +84,13 @@ nl:
         subject: "Je bent automatisch aangemeld voor %{activity}"
         havenot_responded: "Je hebt nog niet aangegeven of je bij %{activity} kunt zijn. Omdat we ervan uitgaan dat je er bent als je niks aangeeft, is je reactie automatisch op 'aanwezig' gezet."
         if_cannot: "Als je toch niet aanwezig kunt zijn, kan je dit tot %{deadline} aangeven via de volgende link:"
+      subgroup_notification:
+        subject: "Je bent ingedeeld in subgroep %{subgroup} voor %{activity}"
+        yoursubgroupis: "De aankomende opkomst %{activity} gebruikt subgroepen, en jij bent ingedeeld in subgroep %{subgroup}."
+        subgroupmembers: "De andere mensen in deze subgroep zijn: %{others}"
+        noothersinsubgroup: "Er zijn geen andere mensen in deze subgroep. :("
+        allsubgroups: "Alle groepjes (inclusief de jouwe) zijn:"
+        cannotdecline: "Deze email is verstuurd toen de deadline voor het afmelden verstreek. Als je om wat voor reden dan ook toch niet kan, neem dan contact op met de Drerrie (afmeld@maartenberg.nl) of een van de organisators van de opkomst (%{organizers})."
 
     subgroups:
       manage: 'Subgroepen aanpassen'