ソースを参照

Redundant parentheses

Maarten van den Berg 6 年 前
コミット
d7fd51c66e
共有3 個のファイルを変更した7 個の追加19 個の削除を含む
  1. 0 12
      .rubocop.yml
  2. 2 2
      app/models/activity.rb
  3. 5 5
      db/seeds.rb

+ 0 - 12
.rubocop.yml

234
   Exclude:
234
   Exclude:
235
     - 'config/spring.rb'
235
     - 'config/spring.rb'
236
 
236
 
237
-# Offense count: 2
238
-# Cop supports --auto-correct.
239
-Style/Proc:
240
-  Exclude:
241
-    - 'app/models/activity.rb'
242
-
243
-# Offense count: 5
244
-# Cop supports --auto-correct.
245
-Style/RedundantParentheses:
246
-  Exclude:
247
-    - 'db/seeds.rb'
248
-
249
 # Offense count: 85
237
 # Offense count: 85
250
 # Cop supports --auto-correct.
238
 # Cop supports --auto-correct.
251
 Style/RedundantSelf:
239
 Style/RedundantSelf:

+ 2 - 2
app/models/activity.rb

75
   after_create :schedule_subgroup_division
75
   after_create :schedule_subgroup_division
76
 
76
 
77
   after_commit :schedule_reminder,
77
   after_commit :schedule_reminder,
78
-               if: Proc.new { |a| a.previous_changes["reminder_at"] }
78
+               if: proc { |a| a.previous_changes["reminder_at"] }
79
   after_commit :schedule_subgroup_division,
79
   after_commit :schedule_subgroup_division,
80
-               if: Proc.new { |a|
80
+               if: proc { |a|
81
                      (a.previous_changes['deadline'] ||
81
                      (a.previous_changes['deadline'] ||
82
                                    a.previous_changes['subgroup_division_enabled']) &&
82
                                    a.previous_changes['subgroup_division_enabled']) &&
83
                        !a.subgroup_division_done &&
83
                        !a.subgroup_division_done &&

+ 5 - 5
db/seeds.rb

13
   first_name: 'Maarten',
13
   first_name: 'Maarten',
14
   infix: 'van den',
14
   infix: 'van den',
15
   last_name: 'Berg',
15
   last_name: 'Berg',
16
-  birth_date: (Faker::Date.between(21.years.ago, Date.today)),
16
+  birth_date: Faker::Date.between(21.years.ago, Date.today),
17
   email: 'maarten@maartenberg.nl',
17
   email: 'maarten@maartenberg.nl',
18
   is_admin: true
18
   is_admin: true
19
 )
19
 )
29
 Person.create!(
29
 Person.create!(
30
   first_name: 'Henkie',
30
   first_name: 'Henkie',
31
   last_name: 'Gekke',
31
   last_name: 'Gekke',
32
-  birth_date: (Faker::Date.between(21.years.ago, Date.today)),
32
+  birth_date: Faker::Date.between(21.years.ago, Date.today),
33
   email: 'gekkehenkie@maartenberg.nl'
33
   email: 'gekkehenkie@maartenberg.nl'
34
 )
34
 )
35
 
35
 
45
 
45
 
46
 15.times do
46
 15.times do
47
   Person.create!(
47
   Person.create!(
48
-    first_name: (Faker::Name.first_name),
49
-    last_name: (Faker::Name.last_name),
50
-    birth_date: (Faker::Date.between(21.years.ago, Date.today)),
48
+    first_name: Faker::Name.first_name,
49
+    last_name: Faker::Name.last_name,
50
+    birth_date: Faker::Date.between(21.years.ago, Date.today),
51
     email: "testuser#{i}@maartenberg.nl"
51
     email: "testuser#{i}@maartenberg.nl"
52
   )
52
   )
53
 end
53
 end