Remove birth date from people

app/controllers/members_controller.rb

@@ -151,6 +151,6 @@ class MembersController < ApplicationController
   # through.  Note: differs from the ones in PeopleController because
   # creating admins is not allowed.
   def invite_params
-    params.require(:person).permit(:first_name, :infix, :last_name, :email, :birth_date)
+    params.require(:person).permit(:first_name, :infix, :last_name, :email)
   end
 end

app/controllers/people_controller.rb

@@ -108,6 +108,6 @@ class PeopleController < ApplicationController
 
   # Never trust parameters from the scary internet, only allow the white list through.
   def person_params
-    params.require(:person).permit(:first_name, :infix, :last_name, :email, :birth_date, :is_admin)
+    params.require(:person).permit(:first_name, :infix, :last_name, :email, :is_admin)
   end
 end

app/models/person.rb

@@ -17,10 +17,6 @@ class Person < ApplicationRecord
   #   @return [String]
   #     the person's surname. ('Gogh' in 'Vincent van Gogh'.)
   #
-  # @!attribute birth_date
-  #   @return [Date]
-  #     the person's birth date.
-  #
   # @!attribute email
   #   @return [String]
   #     the person's email address.
@@ -47,8 +43,6 @@ class Person < ApplicationRecord
   validates :first_name, presence: true
   validates :last_name, presence: true
 
-  validate :birth_date_cannot_be_in_future
-
   before_validation :not_admin_if_nil
   before_save :update_user_email, if: :email_changed?
 
@@ -88,7 +82,6 @@ class Person < ApplicationRecord
         p.infix       = row['infix']
         p.last_name   = row['last_name']
         p.email       = row['email']
-        p.birth_date  = Date.strptime(row['birth_date']) if row['birth_date'].present?
         p.save!
       end
       result << p
@@ -188,11 +181,6 @@ class Person < ApplicationRecord
 
   private
 
-  # Assert that the person's birth date, if any, lies in the past.
-  def birth_date_cannot_be_in_future
-    errors.add(:birth_date, I18n.t('person.errors.cannot_future')) if birth_date&.future?
-  end
-
   # Explicitly force nil to false in the admin field.
   def not_admin_if_nil
     self.is_admin ||= false

app/views/people/_form.html.erb

@@ -24,10 +24,6 @@
       <%= f.label :email %>
       <%= f.email_field :email, class: 'form-control' %>
     </div>
-    <div class="form-group">
-      <%= f.label :birth_date %>
-      <%= f.date_field :birth_date, type: 'date', class: 'form-control' %>
-    </div>
     <% unless defined? no_admin %>
       <div class="form-group">
         <%= f.check_box :is_admin %>

app/views/people/show.html.erb

@@ -1,6 +1,5 @@
 <h2><%= @person.full_name %></h2>
 <ul>
-  <li><%= @person.birth_date %></li>
   <li><%= @person.email %></li>
   <li>AttendanceReminder: <%= @person.send_attendance_reminder.to_s %></li>
 </ul>

config/locales/aardbei_en.yml

@@ -77,7 +77,6 @@ en:
         infix: "Infix"
         last_name: "Last name"
         email: "Email address"
-        birth_date: "Date of birth"
 
       group:
         name: "Name"

config/locales/translation_nl.yml

@@ -79,7 +79,6 @@ nl:
 
       person:
         activities: Activiteiten  #g
-        birth_date: Geboortedatum  #g
         email: Emailadres  #g
         first_name: Voornaam  #g
         groups: Groepen  #g

db/migrate/20190203193638_remove_birth_date_from_people.rb

@@ -0,0 +1,5 @@
+class RemoveBirthDateFromPeople < ActiveRecord::Migration[5.0]
+  def change
+    remove_column :people, :birth_date, :date
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20181104220610) do
+ActiveRecord::Schema.define(version: 20190203193638) do
 
   create_table "activities", force: :cascade do |t|
     t.string   "name"
@@ -92,7 +92,6 @@ ActiveRecord::Schema.define(version: 20181104220610) do
     t.string   "first_name"
     t.string   "infix"
     t.string   "last_name"
-    t.date     "birth_date"
     t.string   "email"
     t.boolean  "is_admin"
     t.datetime "created_at",                              null: false

db/seeds.rb

@@ -13,7 +13,6 @@ its_me = Person.create!(
   first_name: 'Maarten',
   infix: 'van den',
   last_name: 'Berg',
-  birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
   email: 'maarten@maartenberg.nl',
   is_admin: true
 )
@@ -29,7 +28,6 @@ User.create!(
 Person.create!(
   first_name: 'Henkie',
   last_name: 'Gekke',
-  birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
   email: 'gekkehenkie@maartenberg.nl'
 )
 
@@ -47,7 +45,6 @@ end
   Person.create!(
     first_name: Faker::Name.first_name,
     last_name: Faker::Name.last_name,
-    birth_date: Faker::Date.between(21.years.ago, Time.zone.today),
     email: "testuser#{i}@maartenberg.nl"
   )
 end

public/batch_persons.csv

@@ -1,2 +1,2 @@
-first_name,infix,last_name,birth_date,email
-Gekke,,Henkie,1-1-1997,gekkehenkie@maartenberg.nl
+first_name,infix,last_name,email
+Gekke,,Henkie,gekkehenkie@maartenberg.nl

test/fixtures/people.yml

@@ -4,7 +4,6 @@ one:
   first_name: MyString
   infix: MyString
   last_name: MyString
-  birth_date: 2016-12-07
   email: MyString
   is_admin: 
 
@@ -12,6 +11,5 @@ two:
   first_name: MyString
   infix: MyString
   last_name: MyString
-  birth_date: 2016-12-07
   email: MyString
   is_admin: