Browse Source

Redundant parentheses

Maarten van den Berg 6 years ago
parent
commit
d7fd51c66e
3 changed files with 7 additions and 19 deletions
  1. 0 12
      .rubocop.yml
  2. 2 2
      app/models/activity.rb
  3. 5 5
      db/seeds.rb

+ 0 - 12
.rubocop.yml

@@ -234,18 +234,6 @@ Style/PercentLiteralDelimiters:
234 234
   Exclude:
235 235
     - 'config/spring.rb'
236 236
 
237
-# Offense count: 2
238
-# Cop supports --auto-correct.
239
-Style/Proc:
240
-  Exclude:
241
-    - 'app/models/activity.rb'
242
-
243
-# Offense count: 5
244
-# Cop supports --auto-correct.
245
-Style/RedundantParentheses:
246
-  Exclude:
247
-    - 'db/seeds.rb'
248
-
249 237
 # Offense count: 85
250 238
 # Cop supports --auto-correct.
251 239
 Style/RedundantSelf:

+ 2 - 2
app/models/activity.rb

@@ -75,9 +75,9 @@ class Activity < ApplicationRecord
75 75
   after_create :schedule_subgroup_division
76 76
 
77 77
   after_commit :schedule_reminder,
78
-               if: Proc.new { |a| a.previous_changes["reminder_at"] }
78
+               if: proc { |a| a.previous_changes["reminder_at"] }
79 79
   after_commit :schedule_subgroup_division,
80
-               if: Proc.new { |a|
80
+               if: proc { |a|
81 81
                      (a.previous_changes['deadline'] ||
82 82
                                    a.previous_changes['subgroup_division_enabled']) &&
83 83
                        !a.subgroup_division_done &&

+ 5 - 5
db/seeds.rb

@@ -13,7 +13,7 @@ its_me = Person.create!(
13 13
   first_name: 'Maarten',
14 14
   infix: 'van den',
15 15
   last_name: 'Berg',
16
-  birth_date: (Faker::Date.between(21.years.ago, Date.today)),
16
+  birth_date: Faker::Date.between(21.years.ago, Date.today),
17 17
   email: 'maarten@maartenberg.nl',
18 18
   is_admin: true
19 19
 )
@@ -29,7 +29,7 @@ User.create!(
29 29
 Person.create!(
30 30
   first_name: 'Henkie',
31 31
   last_name: 'Gekke',
32
-  birth_date: (Faker::Date.between(21.years.ago, Date.today)),
32
+  birth_date: Faker::Date.between(21.years.ago, Date.today),
33 33
   email: 'gekkehenkie@maartenberg.nl'
34 34
 )
35 35
 
@@ -45,9 +45,9 @@ end
45 45
 
46 46
 15.times do
47 47
   Person.create!(
48
-    first_name: (Faker::Name.first_name),
49
-    last_name: (Faker::Name.last_name),
50
-    birth_date: (Faker::Date.between(21.years.ago, Date.today)),
48
+    first_name: Faker::Name.first_name,
49
+    last_name: Faker::Name.last_name,
50
+    birth_date: Faker::Date.between(21.years.ago, Date.today),
51 51
     email: "testuser#{i}@maartenberg.nl"
52 52
   )
53 53
 end